feat(datagrid): toggle filter with Cmd+F when grid is focused#1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cmd+Fis now context-aware:Cmd+Shift+Fis removed as the default shortcut for "Toggle Filters". The Edit menu "Toggle Filters" item stays accessible without a default binding; users can rebind in Settings → Keyboard Shortcuts if they want their old habit back.Why
The previous
Cmd+Shift+Ffor filters added a modifier where most users expect a Filter shortcut to match the native Find-styleCmd+F. Inspector windows already routedCmd+Fto filter; this PR extends the same logic to the main data grid.Changes
TableProApp.swift"Find..." menu button: adds a branch forfirstResponder is KeyHandlingTableView && actions?.isTableTab == true→toggleFilterPanel(). Editor branch unchanged.KeyboardShortcutModels.swift: removes the.toggleFiltersdefault keymap entry. The action stays in the enum so users keep their saved customizations; only the factory default is gone.docs/features/filtering.mdx,docs/features/keyboard-shortcuts.mdx.Changed.Test plan
xcodebuild -project TablePro.xcodeproj -scheme TablePro test -skipPackagePluginValidationCmd+F→ filter panel togglesCmd+F→ editor Find panel opensCmd+F→ inspector filter togglesCmd+F→ editor Find panel fallback (or no-op if no editor).toggleFiltersshows up with no default and can be assigned to any combo by the user